Skip to content

notify me when rdg is touched #142904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

notify me when rdg is touched #142904

merged 1 commit into from
Jun 23, 2025

Conversation

tshepang
Copy link
Member

r? jieyouxu

@rustbot
Copy link
Collaborator

rustbot commented Jun 23, 2025

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 23, 2025

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot

This comment has been minimized.

Sign in to view
jieyouxu
jieyouxu approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kewl

@jieyouxu
Copy link
Member

Ah yeah, can you remove the r? @jieyouxu in commit message, otherwise that will ping me every time that commit gets reproduced, I think :ferrisclueless:

@bors delegate+ (r=me after that)

@bors
Copy link
Collaborator

bors commented Jun 23, 2025

✌️ @tshepang, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

@jieyouxu jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2025
@tshepang
Copy link
Member Author

@bors r=@jieyouxu

@bors
Copy link
Collaborator

bors commented Jun 23, 2025

📌 Commit 9dd7bcb has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 23, 2025
@jieyouxu
Copy link
Member

@bors rollup

jdonszelmann added a commit to jdonszelmann/rust that referenced this pull request Jun 23, 2025
@jdonszelmann
Rollup merge of rust-lang#142904 - tshepang:patch-1, r=jieyouxu
d017466 
notify me when rdg is touched

r? jieyouxu
This was referenced Jun 23, 2025
Closed
Merged
bors added a commit that referenced this pull request Jun 23, 2025
@bors
Auto merge of #142906 - jdonszelmann:rollup-togt1dl, r=jdonszelmann
42245d3 
Rollup of 5 pull requests

Successful merges:

 - #142493 (rework `#[naked]` attribute parser)
 - #142636 (bootstrap.example.toml: use less contextual format)
 - #142822 (Make `PartialEq` a `const_trait`)
 - #142892 (Fix ICE on debug builds where lints are delayed on the crate root)
 - #142904 (notify me when rdg is touched)

Failed merges:

 - #142827 (Move error code explanation removal check into tidy)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3e8e065 into rust-lang:master Jun 23, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Jun 23, 2025
@rust-timer
Unrolled build for #142904
a9fa447 
Rollup merge of #142904 - tshepang:patch-1, r=jieyouxu

notify me when rdg is touched

r? jieyouxu
@rustbot rustbot added this to the 1.89.0 milestone Jun 23, 2025
@tshepang tshepang deleted the patch-1 branch June 23, 2025 16:49
@cuviper cuviper modified the milestones: 1.89.0, 1.90.0 Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tshepang @rustbot @jieyouxu @bors @cuviper